Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navbar z-index #16690

Merged

Conversation

jenswittmann
Copy link
Contributor

What does it do?

The z-index is too high and prevents extras like ace/tinymce/commerce modal and so on being on top.

Why is it needed?

See #16684.

How to test

Replace manager/templates/default/css/index.css with this demo file.

@jenswittmann jenswittmann force-pushed the a11y_managermenu_bugfix_navbar_zindex branch from 05e1e14 to 8f64a38 Compare January 23, 2025 10:59
Copy link
Collaborator

@smg6511 smg6511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, works!

@modxcommunity
Copy link
Collaborator

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/3-1-0-issue-with-ace-editor-fullscreen/8267/2

@opengeek opengeek changed the title [3.1] A11y/ManagerMenu: bugfix navbar z-index Fix navbar z-index Jan 30, 2025
jenswittmann and others added 2 commits January 30, 2025 16:06
The z-index is too high and prevents extras like ace/tinymce/commerce modal and so on being on top.
@opengeek opengeek force-pushed the a11y_managermenu_bugfix_navbar_zindex branch from 8f64a38 to 8c987bd Compare January 30, 2025 23:07
@opengeek opengeek merged commit b5a3c49 into modxcms:3.x Jan 30, 2025
7 checks passed
@jenswittmann jenswittmann deleted the a11y_managermenu_bugfix_navbar_zindex branch January 31, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants